Support for Roslyn nullable annotations #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikApption
changed the title
# Conflicts: # src/Parquet/Parquet.csproj
aloneguid
approved these changes
Sep 6, 2024
|
Sorry, will have to revert this as it changes default behavior. My bad, I missed it during PR review. |
|
I could look at revising this pr to disable nullable support by default but any chances to consider changing the default in version 5? Working with files that are not generated by parquet.net is not intuitive without nullable support. There might be a compromise to limit issues and load null values into non nullable fields and simply show a warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for bug #535. The current parquet.net doesn't leverage compiler nullable when checking if members are nullable. This affects all classes - so any
stringproperty was marked as nullable in the schema. This PR adds checks for Roslyn's annotations to ensure that a field is nullable.