Fix return of Decode methods to returning the actual destination length. #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloneguid
requested changes
Sep 6, 2024
Further, reduce duplicated code by introduce `Decode<T>(...) where T : struct`.
artnim
force-pushed
the
542-fix-index-out-of-range-exception
branch
from
58cb0f7
to
bff8d28
Compare
Just resolved the conflict around unneeded usings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #542
Caused by
Decodewas returning the length of the source divided by the sizeof(T) instead of the length of the actually decoded data.