Pass property attributes down to list data field #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes decorating a list-type class member are not accessible to ConstructDataField when creating the element data field. This commit passes the ClassMember object representing the list down to ConstructListField so that it can pass it to MakeField for the list element. This allows decorating a list of strings with, for example, ParquetRequired, so that the list elements are not nullable. Or a list of DateTimes as ParquetTimestamp, to control how the DateTime elements are serialized.
|
Thanks, this might help with #502. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes decorating a list-type class member are not accessible to ConstructDataField when creating the element data field. This commit passes the ClassMember object representing the list down to ConstructListField so that it can pass it to MakeField for the list element. This allows decorating a list of strings with, for example, ParquetRequired, so that the list elements are not nullable. Or a list of DateTimes as ParquetTimestamp, to control how the DateTime elements are serialized.