Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#537 (Crypto demo APIError) Hotfix #538

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

jmccarey
Copy link
Contributor

A hotfix for #537 by changing the symbol string before and after managing positions in the crypto demo.

@jmccarey jmccarey requested a review from hiohiohio as a code owner December 14, 2024 20:04
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR and good catch! Overall LGTM! Left a small comment.

examples/crypto-trading-basic.ipynb Outdated Show resolved Hide resolved
Co-authored-by: hiohiohio <hiohiohio@users.noreply.github.com>
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@hiohiohio hiohiohio merged commit 4fe5eb8 into alpacahq:master Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Crypto Demo: Not found for https://paper-api.alpaca.markets/v2/positions/BTC/USD
2 participants