Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication in REST and streaming clients #406

Open
2 of 4 tasks
OlegRa opened this issue Oct 31, 2021 · 0 comments
Open
2 of 4 tasks

Reduce code duplication in REST and streaming clients #406

OlegRa opened this issue Oct 31, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@OlegRa
Copy link
Collaborator

OlegRa commented Oct 31, 2021

The current approach for handling stocks and crypto historical data and streaming is good from the user perspective. But in fact, it's a result of a massive copy-paste-edit approach and it's hard to maintain such code in long term. I've made some changes in the 6.0.1 branch but it's not enough for a truly DRY solution.

Perspective areas of improvements:

  • REST clients configuration types and related environment extension methods
  • Historical data single/multi symbols requests and converting each type into another
  • Helper methods for ADTV calculation (how to create request type properly?)
  • Helper methods for SMA calculation (convert normal IEnumerable into async one)
@OlegRa OlegRa added the enhancement New feature or request label Oct 31, 2021
@OlegRa OlegRa added this to the SDK 6.0.x Experimental milestone Oct 31, 2021
@OlegRa OlegRa self-assigned this Oct 31, 2021
@OlegRa OlegRa modified the milestones: SDK 7.x LTS, SDK 8.x STS (WIP) Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant