Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(cmd): url parse bug #520

Merged
merged 2 commits into from
Oct 14, 2021
Merged

bugfix(cmd): url parse bug #520

merged 2 commits into from
Oct 14, 2021

Conversation

dakimura
Copy link
Contributor

WHAT

  • bugfix: unsupported protocol scheme error is shown when marketstore connect --url *** command is used

WHY

  • my previous refactor introduced a bug.
    http:// prefix must be added to the url before it is passed to rpcClient, err := client.NewClient(url)

@dakimura dakimura merged commit 00eee5f into master Oct 14, 2021
@dakimura dakimura deleted the bugfix/url-connect branch October 14, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dakimura