-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed typedef uint32_richtig_huebsch #100
removed typedef uint32_richtig_huebsch #100
Conversation
- replaced by `uint32_t` from `<boost/cstdint.hpp>`
@@ -100,7 +101,7 @@ namespace CUDA | |||
|
|||
|
|||
#define warp_serial \ | |||
for (uint32_richtig_huebsch __mask = __ballot(1), \ | |||
for (uint32_t __mask = __ballot(1), \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the header signatures of these CUDA intrinsics are unfortunately unsigned int.
I would therefore either write this explicitly or keep a typedef (with an other name) but not assuming uint32_t
.
we can check the header files again to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, well spotted!
I will use the type directly, since this is the only line where this problem occurs.
I would pass this to @psychocoderHPC if that is ok :) |
why do you need boost headers and not simple |
The rest of the project already uses AFAIK, |
oh true, I didn't know |
@@ -100,7 +101,7 @@ namespace CUDA | |||
|
|||
|
|||
#define warp_serial \ | |||
for (uint32_richtig_huebsch __mask = __ballot(1), \ | |||
for (unsigned int __mask = __ballot(1), \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the backslash \
is not aligned
removed typedef uint32_richtig_huebsch
uint32_t
from<boost/cstdint.hpp>