Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed typedef uint32_richtig_huebsch #100

Merged

Conversation

slizzered
Copy link
Contributor

  • replaced by uint32_t from <boost/cstdint.hpp>

 - replaced by `uint32_t` from `<boost/cstdint.hpp>`
@@ -100,7 +101,7 @@ namespace CUDA


#define warp_serial \
for (uint32_richtig_huebsch __mask = __ballot(1), \
for (uint32_t __mask = __ballot(1), \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the header signatures of these CUDA intrinsics are unfortunately unsigned int.

I would therefore either write this explicitly or keep a typedef (with an other name) but not assuming uint32_t.
we can check the header files again to be sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, well spotted!
I will use the type directly, since this is the only line where this problem occurs.

@ax3l
Copy link
Member

ax3l commented Sep 18, 2015

I would pass this to @psychocoderHPC if that is ok :)

@ax3l ax3l assigned psychocoderHPC and unassigned ax3l Sep 18, 2015
@ax3l
Copy link
Member

ax3l commented Sep 18, 2015

why do you need boost headers and not simple <cstdint> from the std libs?

@slizzered
Copy link
Contributor Author

The rest of the project already uses <boost/cstdint.hpp>, so it was used for consistency.

AFAIK, <cstdint> is not available on Windows unless you use C++11, which was explicity not targeted at the time. So the Boost solution is mostly about compatibility between platforms and compiler versions.

@ax3l
Copy link
Member

ax3l commented Sep 18, 2015

oh true, I didn't know <cstdint> first became part of the stdlibs outside the *nix world in C++11

@@ -100,7 +101,7 @@ namespace CUDA


#define warp_serial \
for (uint32_richtig_huebsch __mask = __ballot(1), \
for (unsigned int __mask = __ballot(1), \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the backslash \ is not aligned

psychocoderHPC added a commit that referenced this pull request Sep 24, 2015
@psychocoderHPC psychocoderHPC merged commit 3b91c67 into alpaka-group:dev Sep 24, 2015
This was referenced Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants