Fit accessblocksize into heap for examples and tests
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added an identical fix for |
chillenzer
force-pushed
the
fix-examples
branch
from
b5be10c
to
2c90b40
Compare
chillenzer
changed the title
accessblocksize into heap for examples and tests
|
@psychocoderHPC should we include this into the upcoming release or close? |
Merged
psychocoderHPC
approved these changes
Aug 23, 2024
chillenzer
force-pushed
the
fix-examples
branch
from
2c90b40
to
3c1fa4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As realised by @psychocoderHPC,
accessblocksizedidn't fit into the total allocation size such that no pages were actually created. Now, examples are runnable again.