Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non chunk size resetting #256

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

chillenzer
Copy link
Contributor

Fixes a deadlock popping up applying the test suite for FlatterScatter to Scatter.

@chillenzer chillenzer marked this pull request as draft August 23, 2024 12:36
@chillenzer
Copy link
Contributor Author

Offline discussion: This is not so much a bug as a misimplementation of the resetfreedpages feature because it simply means that pages are potentially left with a chunk size while no thread holds memory there. While it can have unfortunate implications concerning memory availability (which led to deadlocking in the stress test code, i.e. user code), it is not an urgent bug in the strict sense or a deadlock in the library code. Setting this to draft as a reminder that we might want to do a major refactoring of the algorithm in order to establish an invariant that can be used to prove correctness then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant