fix unconditional usage of getAvailableSlotsHost #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `getAvailableSlotsHost` function of a `CreationPolicy` is required irrespective of its availability. In the [source](https://github.com/ComputationalRadiationPhysics/mallocMC/blob/84c8c20309633c98f69be83153eb897ce2d83110/src/include/mallocMC/mallocMC_hostclass.hpp#L144-155) the `CreationPolicy::providesAvailableSlots::value` flag is checked in a runtime `if` so the function is required for all CreationPolicies even for `OldMalloc`. This has been changed to a compile time construct.
|
@slizzered can you pls take a look? :) |
|
I like the solution a lot, thanks @BenjaminW3 ! |
slizzered
added a commit
that referenced
this pull request
Jul 7, 2015
fix unconditional usage of getAvailableSlotsHost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
getAvailableSlotsHostfunction of aCreationPolicyis required irrespective of its availability.In the source the
CreationPolicy::providesAvailableSlots::valueflag is checked in a runtimeifso the function is required for all CreationPolicies even forOldMalloc.This has been changed to a compile time construct.
See issue #88.