Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(btcio): remove bitcoind_json_rpc_types #424

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

storopoli
Copy link
Member

It does not make sense to have this dep since we're already half-baking
our own custom types on top of it and using only a tiny minority of the
types as being the ones provided by bitcoind_json_rpc_types.

@storopoli storopoli requested a review from Zk2u October 22, 2024 12:26
@storopoli
Copy link
Member Author

One less dependency @delbonis.

It does not make sense to have this dep since we're already half-baking
our own custom types on top of it and using only a tiny minority of the
types as being the ones provided by bitcoind_json_rpc_types.
@storopoli storopoli force-pushed the storopoli/remove-bitcoind-json-rpc-types branch from 57ae50d to 4af0042 Compare October 22, 2024 12:42
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.73%. Comparing base (a2d835c) to head (4af0042).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/btcio/src/rpc/types.rs 61.53% 5 Missing ⚠️
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   57.74%   57.73%   -0.01%     
==========================================
  Files         263      263              
  Lines       27538    27551      +13     
==========================================
+ Hits        15902    15907       +5     
- Misses      11636    11644       +8     
Files with missing lines Coverage Δ
crates/btcio/src/rpc/client.rs 88.47% <ø> (ø)
crates/btcio/src/rpc/types.rs 53.08% <61.53%> (+0.73%) ⬆️

... and 5 files with indirect coverage changes

@storopoli storopoli merged commit b446af3 into main Oct 22, 2024
17 checks passed
@storopoli storopoli deleted the storopoli/remove-bitcoind-json-rpc-types branch October 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants