Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guest code cargo update #438

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Guest code cargo update #438

merged 1 commit into from
Oct 28, 2024

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Oct 28, 2024

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@MdTeach MdTeach force-pushed the feat/guest-code-cargo-update branch from d3aafe5 to 05fe521 Compare October 28, 2024 17:35
delbonis
delbonis approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think.

storopoli
storopoli approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 05fe521

Apart from the prover crates that I don't have much knowledge the rust-bitcoin 0.32.3 is in-sync with strata's root level Cargo.toml.

@MdTeach MdTeach merged commit cb20bb4 into releases/0.1.0 Oct 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delbonis delbonis delbonis approved these changes

@storopoli storopoli storopoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MdTeach @delbonis @storopoli