Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print strata explorer links if configured #453

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Zk2u
Copy link
Contributor

@Zk2u Zk2u commented Nov 5, 2024

Description

This commit adds the ability to log a link to any transactions made on Strata if a explorer URL is configured

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Closes STR-554

@Zk2u Zk2u added the enhancement New feature or request label Nov 5, 2024
@Zk2u Zk2u requested a review from storopoli November 5, 2024 11:18
@Zk2u Zk2u self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (59a60f3) to head (3052830).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/strata-cli/src/strata.rs 0.00% 12 Missing ⚠️
bin/strata-cli/src/signet.rs 0.00% 11 Missing ⚠️
bin/strata-cli/src/cmd/drain.rs 0.00% 4 Missing ⚠️
bin/strata-cli/src/settings.rs 0.00% 4 Missing ⚠️
bin/strata-cli/src/cmd/faucet.rs 0.00% 2 Missing ⚠️
bin/strata-cli/src/cmd/send.rs 0.00% 2 Missing ⚠️
bin/strata-cli/src/cmd/withdraw.rs 0.00% 2 Missing ⚠️
bin/strata-cli/src/cmd/deposit.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   56.98%   56.98%   -0.01%     
==========================================
  Files         266      266              
  Lines       27982    28002      +20     
==========================================
+ Hits        15946    15957      +11     
- Misses      12036    12045       +9     
Files with missing lines Coverage Δ
bin/strata-cli/src/cmd/deposit.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/faucet.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/send.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/withdraw.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/drain.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/settings.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/signet.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/strata.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 59e3eba74ad4906e4257dc46dfc38130ec58286b

@storopoli storopoli merged commit 603442d into main Nov 5, 2024
16 of 17 checks passed
@storopoli storopoli deleted the feat/cli-strata-explorer branch November 5, 2024 12:25
storopoli pushed a commit that referenced this pull request Nov 5, 2024
* feat: print strata explorer links if configured

* fix: don't rename the file name for bitcoin explorer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants