Fix resubmit checkpoint bug

[voidash]

Description

Since anyone can post inscriptions, a malicious user can resend checkpoint inscription that has already been published and sequencer stops working. This PR fixes that particular bug

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactor
• New or updated tests
• Dependency Update

Notes to Reviewers

Checklist

This

• I have performed a self-review of my code.
• I have commented my code where necessary.
• I have updated the documentation if needed.
• My changes do not introduce new warnings.
• I have added tests that prove my changes are effective or that my feature works.
• New and existing tests pass with my changes.

Related Issues

STR-795

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 57.32%. Comparing base (506fd5c) to head (055793d).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...rates/consensus-logic/src/csm/client_transition.rs	0.00%	22 Missing ⚠️

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   57.33%   57.32%   -0.02%     
==========================================
  Files         309      309              
  Lines       31510    31509       -1     
==========================================
- Hits        18067    18062       -5     
- Misses      13443    13447       +4     

Files with missing lines	Coverage Δ
...rates/consensus-logic/src/csm/client_transition.rs	58.81% <0.00%> (+0.10%)	⬆️

... and 3 files with indirect coverage changes

[delbonis]

How does this change fix the bug? I would expect that the change would be to check if the epoch is less than or equal to the current finalized epoch then we just ignore it the checkpoint. I don't follow what was changed.

[voidash]

How does this change fix the bug? I would expect that the change would be to check if the epoch is less than or equal to the current finalized epoch then we just ignore it the checkpoint. I don't follow what was changed.

There was already a check present in the code. Instead of passing those filtered checkpoints, we were passing the initial checkpoint vector. Changing it to filtered checkpoint fixes the problem

[bewakes]

Some minor comments.

[storopoli]

ACK 055793d