chore(deps): bump bdk wallet & friends to 1.0.0 #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storopoli
commented
Dec 19, 2024
| bdk_esplora = { version = "0.20.1", features = [ | ||
| "async-https", | ||
| "async-https-rustls", | ||
| "tokio", |
There was a problem hiding this comment.
This is needed now 😓 Cc @Zk2u
storopoli
commented
Dec 19, 2024
Comment on lines
+82
to
+92
| // F***! BDK 1.0 removed the `insert_tx` method, so we have to do this the hard way | ||
| // Taken from https://github.com/bitcoindevkit/bdk/pull/1658/commits/3135e291d777d474ab4b76de36d43a96ff104a3c | ||
| recovery_wallet.transactions().for_each(|tx| { | ||
| l1w.insert_tx(tx.tx_node.tx); | ||
| l1w.apply_update(Update { | ||
| tx_update: TxUpdate { | ||
| txs: vec![tx.tx_node.tx], | ||
| ..Default::default() | ||
| }, | ||
| ..Default::default() | ||
| }) | ||
| .expect("could not insert transaction"); |
There was a problem hiding this comment.
IIRC you can use the apply_unconfirmed_txs.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 56.76% 56.75% -0.02%
==========================================
Files 306 306
Lines 31263 31264 +1
==========================================
- Hits 17747 17743 -4
- Misses 13516 13521 +5
|
delbonis
approved these changes
Dec 19, 2024
AaronFeickert
approved these changes
Dec 20, 2024
| @@ -76,8 +79,17 @@ pub async fn recover(args: RecoverArgs, seed: Seed, settings: Settings) { | |||
| continue; | |||
| } | |||
|
|
|||
| // F***! BDK 1.0 removed the `insert_tx` method, so we have to do this the hard way | |||
There was a problem hiding this comment.
Is there an issue filed on this?
There was a problem hiding this comment.
No, but as said above we can use method.apply_unconfirmed_txs.
Just waiting input from @Zk2u since he did a lot of development as well with BDK in Strata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BDK 1.0.0 has been released. No more betas!
See: https://github.com/bitcoindevkit/bdk/releases/tag/wallet-1.0.0
Type of Change
Notes to Reviewers
Checklist