Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Configurable Checkpointing Interval for Client State #218

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

prajwolrg
Copy link
Contributor

@prajwolrg prajwolrg commented Aug 8, 2024

Description

This PR does the following:

  • Checkpoints client state at configurable regular intervals
  • Fixes attempt to subtract with overflow

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Closes #140
Closes EXP-112

@prajwolrg prajwolrg mentioned this pull request Aug 8, 2024
11 tasks
@prajwolrg prajwolrg requested a review from delbonis August 8, 2024 17:11
delbonis
delbonis previously approved these changes Aug 9, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 54.70%. Comparing base (cc7efe8) to head (dda52d2).

Files Patch % Lines
crates/consensus-logic/src/duty/types.rs 0.00% 12 Missing ⚠️
crates/consensus-logic/src/duty/worker.rs 0.00% 11 Missing ⚠️
crates/consensus-logic/src/worker.rs 0.00% 6 Missing ⚠️
crates/consensus-logic/src/duty/block_assembly.rs 0.00% 5 Missing ⚠️
crates/consensus-logic/src/duty/extractor.rs 0.00% 1 Missing ⚠️
sequencer/src/config.rs 50.00% 1 Missing ⚠️
sequencer/src/main.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   54.78%   54.70%   -0.08%     
==========================================
  Files         103      103              
  Lines       11075    11095      +20     
==========================================
+ Hits         6067     6070       +3     
- Misses       5008     5025      +17     
Files Coverage Δ
crates/primitives/src/params.rs 50.00% <ø> (ø)
crates/test-utils/src/l2.rs 98.70% <100.00%> (+0.01%) ⬆️
crates/consensus-logic/src/duty/extractor.rs 0.00% <0.00%> (ø)
sequencer/src/config.rs 31.06% <50.00%> (+0.37%) ⬆️
sequencer/src/main.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/duty/block_assembly.rs 52.98% <0.00%> (+0.62%) ⬆️
crates/consensus-logic/src/worker.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/duty/worker.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/duty/types.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@bewakes bewakes merged commit 3bdaaf5 into master Aug 12, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make client state checkpoint frequency configurable by the user instead of every block
3 participants