-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkpoint only on block finalization #207
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 52.30% 52.20% -0.10%
==========================================
Files 87 87
Lines 8464 8484 +20
==========================================
+ Hits 4427 4429 +2
- Misses 4037 4055 +18
|
delbonis
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should wait until the PR #116 gets merged then rebase this.
prajwolrg
force-pushed
the
145-handle-l1-da-batch
branch
from
August 8, 2024 05:11
6addfe6
to
ffad95b
Compare
prajwolrg
force-pushed
the
145-handle-l1-da-batch
branch
from
August 8, 2024 09:34
ffad95b
to
57ab039
Compare
Closing in favor of PR 128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writes the state checkpoint only when we update finalize block.
Type of Change
Checklist
Related Issues