Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint only on block finalization #207

Closed
wants to merge 3 commits into from

Conversation

prajwolrg
Copy link
Contributor

@prajwolrg prajwolrg commented Aug 5, 2024

Description

Writes the state checkpoint only when we update finalize block.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 4.87805% with 39 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (2c89e7b) to head (57ab039).

Files Patch % Lines
crates/consensus-logic/src/duty/types.rs 0.00% 12 Missing ⚠️
crates/consensus-logic/src/duty/worker.rs 0.00% 11 Missing ⚠️
crates/consensus-logic/src/worker.rs 0.00% 6 Missing ⚠️
crates/consensus-logic/src/duty/block_assembly.rs 0.00% 5 Missing ⚠️
sequencer/src/config.rs 33.33% 2 Missing ⚠️
sequencer/src/main.rs 0.00% 2 Missing ⚠️
crates/consensus-logic/src/duty/extractor.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   52.30%   52.20%   -0.10%     
==========================================
  Files          87       87              
  Lines        8464     8484      +20     
==========================================
+ Hits         4427     4429       +2     
- Misses       4037     4055      +18     
Files Coverage Δ
crates/primitives/src/params.rs 50.00% <ø> (ø)
crates/test-utils/src/l2.rs 98.68% <100.00%> (+0.01%) ⬆️
crates/consensus-logic/src/duty/extractor.rs 0.00% <0.00%> (ø)
sequencer/src/config.rs 36.47% <33.33%> (+0.32%) ⬆️
sequencer/src/main.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/duty/block_assembly.rs 52.98% <0.00%> (+0.62%) ⬆️
crates/consensus-logic/src/worker.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/duty/worker.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/duty/types.rs 0.00% <0.00%> (ø)

Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should wait until the PR #116 gets merged then rebase this.

crates/consensus-logic/src/worker.rs Outdated Show resolved Hide resolved
crates/consensus-logic/src/duty_executor.rs Outdated Show resolved Hide resolved
@prajwolrg prajwolrg self-assigned this Aug 8, 2024
@prajwolrg prajwolrg requested a review from delbonis August 8, 2024 09:18
@prajwolrg prajwolrg marked this pull request as ready for review August 8, 2024 09:45
@prajwolrg
Copy link
Contributor Author

Closing in favor of PR 128

@prajwolrg prajwolrg closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants