Fix deprecation warnings for gradle 7 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changed deprecated dependency config "compile" to "implementation" * changed deprecated property "archiveName" to use "archiveFileName" for bundledJar task * exclude all "LICENSE.txt" and "NOTICE.txt" files from bundled jar (to avoid handling duplicates in classpath, since all apache commons dependencies have their own files of that name which would have to be merged otherwise)
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 79.01% 79% -0.02%
+ Complexity 2072 2071 -1
==========================================
Files 145 145
Lines 6582 6582
Branches 1152 1152
==========================================
- Hits 5201 5200 -1
Misses 979 979
- Partials 402 403 +1
Continue to review full report at Codecov.
|
lorenzleutgeb
requested changes
Jan 14, 2020
AntoniusW
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #214
Note that LICENSE and NOTICE files are excluded from bundled jar in order to avoid having to handle duplicate files since all apache commons dependencies have their own files of that name which would have to be properly handled (ideally merged) otherwise. The aforementioned "proper handling" would require use of the gradle shadow plugin, which unfortunately is not gradle 7 compliant itself (as of version 5.2.0)