Fix bug in justification analysis, address issue #211. #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AnalyzeUnjustified uses more general atom to test for exclusion due to prior analysis, i.e., less atoms are (falsely) discarded. - Unifier can report which variables are mapped.
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
============================================
+ Coverage 79.00% 79.11% +0.11%
- Complexity 2071 2075 +4
============================================
Files 145 145
Lines 6582 6593 +11
Branches 1152 1153 +1
============================================
+ Hits 5200 5216 +16
+ Misses 979 976 -3
+ Partials 403 401 -2
Continue to review full report at Codecov.
|
rtaupe
reviewed
Feb 12, 2020
AntoniusW
changed the title
- Test whether an atom is excluded using all variables occurring in the unifier.
AntoniusW
changed the title
|
Since I did not find the time to construct a minimal working example / failing unit test for this issue in the last months and we have 100% coverage anyway, I'd like to suggest merging this PR sometime soon-ish (@rtaupe). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification analysis used erroneously specific atom to test whether a given substitution is excluded by a more general one. Now a more general atom is constructed for the test. This fixes issue #211, this fix/PR is independent of the phase saving and restarts branch as the bug was just unearthed there but is present in master, too.