Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into phase_saving_and_restarts #224

Merged

Conversation

rtaupe
Copy link
Collaborator

@rtaupe rtaupe commented Feb 19, 2020

No description provided.

madmike200590 and others added 24 commits February 5, 2020 17:03
… txt extension since apache poi bundles them without ext
Feature: Render answer sets as excel workbooks (xlsx files)
Switch to optimized cardinality aggregate normalization.
# Conflicts:
#	src/main/java/at/ac/tuwien/kr/alpha/config/CommandLineParser.java
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #224 into phase_saving_and_restarts will decrease coverage by 0.02%.
The diff coverage is 76.78%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##             phase_saving_and_restarts     #224      +/-   ##
===============================================================
- Coverage                        79.17%   79.15%   -0.03%     
- Complexity                        2158     2176      +18     
===============================================================
  Files                              150      152       +2     
  Lines                             6848     6956     +108     
  Branches                          1185     1195      +10     
===============================================================
+ Hits                              5422     5506      +84     
- Misses                            1018     1040      +22     
- Partials                           408      410       +2
Impacted Files Coverage Δ Complexity Δ
src/main/java/at/ac/tuwien/kr/alpha/api/Alpha.java 84.21% <ø> (ø) 11 <0> (?)
...under/transformation/CardinalityNormalization.java 92.04% <100%> (+0.09%) 18 <0> (ø) ⬇️
...java/at/ac/tuwien/kr/alpha/config/InputConfig.java 71.79% <28.57%> (-9.46%) 15 <1> (+1)
...t/ac/tuwien/kr/alpha/config/CommandLineParser.java 81.55% <38.46%> (-1.78%) 26 <0> (ø)
src/main/java/at/ac/tuwien/kr/alpha/Main.java 46.77% <47.05%> (-1.06%) 5 <2> (+1)
...a/at/ac/tuwien/kr/alpha/AnswerSetToXlsxWriter.java 92.3% <92.3%> (ø) 3 <3> (?)
...pha/api/mapper/impl/AnswerSetToWorkbookMapper.java 95.83% <95.83%> (ø) 14 <14> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ccf70...0fbb0e9. Read the comment docs.

@AntoniusW AntoniusW merged commit f922794 into phase_saving_and_restarts Feb 21, 2020
@AntoniusW AntoniusW deleted the phase_saving_and_restarts_merge_master branch February 21, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants