Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ProgramPartParser to simplify construction of parts of programs #248

Merged
merged 4 commits into from
Jul 10, 2020

Conversation

rtaupe
Copy link
Collaborator

@rtaupe rtaupe commented Apr 22, 2020

Some unit tests already have been adapted to use the new parser for Literals instead of using various constructors, which makes the unit tests easier to understand.

@rtaupe rtaupe requested review from AntoniusW and removed request for madmike200590 April 23, 2020 06:48
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #248 into master will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #248      +/-   ##
============================================
+ Coverage     76.83%   76.91%   +0.07%     
- Complexity     2056     2063       +7     
============================================
  Files           150      151       +1     
  Lines          6782     6814      +32     
  Branches       1184     1189       +5     
============================================
+ Hits           5211     5241      +30     
  Misses         1177     1177              
- Partials        394      396       +2     
Impacted Files Coverage Δ Complexity Δ
...en/kr/alpha/grounder/parser/ProgramPartParser.java 83.33% <83.33%> (ø) 6.00 <6.00> (?)
...a/at/ac/tuwien/kr/alpha/grounder/Substitution.java 77.33% <100.00%> (+1.38%) 29.00 <1.00> (-1.00) ⬆️
...in/java/at/ac/tuwien/kr/alpha/common/Interner.java 90.00% <0.00%> (-10.00%) 3.00% <0.00%> (-1.00%)
.../at/ac/tuwien/kr/alpha/grounder/NaiveGrounder.java 88.34% <0.00%> (+0.52%) 109.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2239eb3...a9efedf. Read the comment docs.

@AntoniusW AntoniusW merged commit a2dd412 into master Jul 10, 2020
@AntoniusW AntoniusW deleted the program_part_parser branch July 10, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants