Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8 #561

Merged
merged 15 commits into from
Nov 6, 2024
Merged

Drop support for Python 3.8 #561

merged 15 commits into from
Nov 6, 2024

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Oct 9, 2024 •
edited by GlassOfWhiskey
Loading

This commit introduces Python 3.9 features in the StreamFlow codebase. This means that StreamFlow no longer supports Python 3.8.

@GlassOfWhiskey GlassOfWhiskey changed the title Added python 3.9 features Drop support for Python 3.8 Oct 14, 2024
@GlassOfWhiskey GlassOfWhiskey force-pushed the remove/python-3-8 branch 3 times, most recently from 4f34ae8 to e142780 Compare October 19, 2024 22:15
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 4, 2024
View reviewed changes
streamflow/core/recovery.py Fixed Show fixed Hide fixed
streamflow/core/recovery.py Fixed Show fixed Hide fixed
streamflow/core/recovery.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 4, 2024
View reviewed changes
streamflow/core/recovery.py Fixed Show fixed Hide fixed
streamflow/core/recovery.py Fixed Show fixed Hide fixed
@LanderOtto LanderOtto force-pushed the remove/python-3-8 branch 3 times, most recently from b54b247 to 1c5d3bf Compare November 4, 2024 15:22
@LanderOtto LanderOtto force-pushed the remove/python-3-8 branch 4 times, most recently from 1c4dc27 to 3c997f1 Compare November 4, 2024 20:47
@LanderOtto LanderOtto force-pushed the remove/python-3-8 branch 8 times, most recently from 7d0d603 to e0d53c3 Compare November 4, 2024 21:58
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.95142% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.63%. Comparing base (63feb26) to head (62f9bbf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
streamflow/provenance/run_crate.py 33.33% 4 Missing ⚠️
streamflow/ext/utils.py 40.00% 3 Missing ⚠️
streamflow/cwl/translator.py 95.23% 1 Missing ⚠️
streamflow/deployment/connector/queue_manager.py 75.00% 1 Missing ⚠️
streamflow/workflow/combinator.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   70.39%   70.63%   +0.23%     
==========================================
  Files          87       87              
  Lines       11010    11063      +53     
  Branches     2288     1909     -379     
==========================================
+ Hits         7751     7814      +63     
+ Misses       2813     2802      -11     
- Partials      446      447       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto marked this pull request as ready for review November 5, 2024 08:11
@GlassOfWhiskey GlassOfWhiskey merged commit d77a5ec into master Nov 6, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the remove/python-3-8 branch November 6, 2024 08:34
LanderOtto added a commit that referenced this pull request Dec 12, 2024
@LanderOtto
This commit definitely removes any reference to python 3.8, which wer…
c71d64b 
…e missed in #561
@LanderOtto LanderOtto mentioned this pull request Dec 12, 2024
Merged
GlassOfWhiskey pushed a commit that referenced this pull request Dec 13, 2024
@LanderOtto
Upgrade pyupgrade target to Python3.9 (#620)
54c811b 
This commit upgrades the `pyupgrade` target Python version to
Python 3.9 and it adapts the code accordingly, completing the work
initiated in #561
GlassOfWhiskey pushed a commit that referenced this pull request Dec 13, 2024
@LanderOtto @GlassOfWhiskey
Upgrade pyupgrade target to Python3.9 (#620)
ce61d4a 
This commit upgrades the `pyupgrade` target Python version to
Python 3.9 and it adapts the code accordingly, completing the work
initiated in #561
GlassOfWhiskey pushed a commit that referenced this pull request Dec 13, 2024
@LanderOtto @GlassOfWhiskey
Upgrade pyupgrade target to Python3.9 (#620)
9660fdc 
This commit upgrades the `pyupgrade` target Python version to
Python 3.9 and it adapts the code accordingly, completing the work
initiated in #561
GlassOfWhiskey pushed a commit that referenced this pull request Dec 13, 2024
@LanderOtto @GlassOfWhiskey
Upgrade pyupgrade target to Python3.9 (#620)
90a078e 
This commit upgrades the `pyupgrade` target Python version to
Python 3.9 and it adapts the code accordingly, completing the work
initiated in #561
LanderOtto added a commit that referenced this pull request Dec 13, 2024
@LanderOtto
Upgrade pyupgrade target to Python3.9 (#620)
5015585 
This commit upgrades the `pyupgrade` target Python version to
Python 3.9 and it adapts the code accordingly, completing the work
initiated in #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GlassOfWhiskey GlassOfWhiskey GlassOfWhiskey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LanderOtto @GlassOfWhiskey