Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize remote commands through StreamFlowPath #626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GlassOfWhiskey
Copy link
Member

This commit relies on the new StreamFlowPath abstraction to redirect file-based commands to the lowest possible ExecutionLocation in the wrapping hierarchy, in order to meet a local location whenever possible. The main benefit of this strategy is that local locations support Python-based commands, which are way faster than shell-based remote processes.

@GlassOfWhiskey GlassOfWhiskey force-pushed the transparent-command-optimization branch from 7c3f263 to 71c4c34 Compare December 14, 2024 08:56
@GlassOfWhiskey GlassOfWhiskey changed the title Optimize remote commands through StreamFlowPath Optimize remote commands through StreamFlowPath Dec 14, 2024
@GlassOfWhiskey GlassOfWhiskey force-pushed the transparent-command-optimization branch 3 times, most recently from aec2ddb to d9f3ed0 Compare December 14, 2024 12:13
@GlassOfWhiskey GlassOfWhiskey force-pushed the transparent-command-optimization branch 3 times, most recently from ab632b5 to cd9eb4b Compare December 14, 2024 22:58
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 84.32836% with 21 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (f83c0cb) to head (43961bc).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
streamflow/data/remotepath.py 84.32% 12 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   71.12%   71.23%   +0.11%     
==========================================
  Files          88       88              
  Lines       11264    11321      +57     
  Branches     1948     1975      +27     
==========================================
+ Hits         8011     8065      +54     
- Misses       2798     2799       +1     
- Partials      455      457       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey force-pushed the transparent-command-optimization branch 2 times, most recently from be41a10 to c584278 Compare December 15, 2024 08:28
This commit relies on the new `StreamFlowPath` abstraction to redirect
file-based commands to the lowest possible `ExecutionLocation` in the
wrapping hierarchy, in order to meet a `local` location whenever
possible. The main benefit of this strategy is that `local` locations
support Python-based commands, which are way faster than shell-based
remote processes.
@GlassOfWhiskey GlassOfWhiskey force-pushed the transparent-command-optimization branch from c584278 to 43961bc Compare December 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants