ariaActivedescendant = false not valid aria

[Jordan-Hall]

Fixes #434

I've used this as the base code for DLUHC. Needed to make small changes to get it to work with plotly dash so migrated from classes to hooks. This is one of the changes we've made to ensure lighthouse was 100.

PS: Happy to push the react hooks changes too if you are interested.

[romaricpascal]

Hi @Jordan-Hall, thanks for contributing this fix. The changes look fine, but there are a couple of logistics bits that need to happen before we can merge them:

• the branch needs to be rebased on main
• dist needs to be re-built to grab the changes
• The GitHub workflows need to run (hopefully pushing the first two changes should trigger that)

Would you be up for doing this or would you prefer I did it (appreciate it took us a bit for us to get to review this, so very fine to do it, thanks for your patience, btw).

On the topics of React hooks, thanks for offering, but we don't have any plans to move towards this. But if you have an open repository at DLUHC, this could be a handy place we could look into for making future decisions 😊

[Jordan-Hall]

Thank you @romaricpascal I'll update the branch later. I left DLUHC now I was only contracting for them but still keep an eye on the repo I started for them. I completely rewrote alot of this to use hooks without losing any functionality.

https://github.com/communitiesuk/gov-uk-dash-react-components/blob/main/src/lib/fragments/AutoComplete.react.js I hope this useful for you. Here some of the changes and PRs we merged into it communitiesuk/gov-uk-dash-react-components#35

[romaricpascal]

Brill! Thanks for the links and offering to update the branch 😊

[colinrotherham]

I've rebased all open PRs with main (where we're able to) including this one

We'd caused a few conflicts by merging #600 first so that's all sorted now

[nicholasgriffintn]

Not related to this pr, but also sort of related, but thanks for getting this going again!

I'm gonna see if there's anything I can add from my fork when this is all done.

[colinrotherham]

Needs a 2nd approval on this one @romaricpascal if you're happy that #553 (comment) is complete?