-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages, configs + Node.js 20 #612
Conversation
c92fb7a
to
33be2a4
Compare
@colinrotherham Wow, thanks, this is a lot of work and looks great. The move to git checkout package-lock.json
rm -rf node_modules
npm cache clear --force # you may not need this, at your own risk, etc — I did need it, though
npm install Now rebasing #611 to see how that goes (to add an integration test)... EDIT: |
Brilliant, thanks for confirming that
Sounds like we might be on different npm versions? $ node -v
v14.21.3 $ npm -v
6.14.18 Hope this idea is alright, but I'll cherry your .nvmrc commit into this branch and we'll close PR #609 Gives us a single place to rebase from and I can work on raising the maximum Node.js version too |
@colinrotherham we're both on 6.14.18 by the looks? Seems to be an issue with that particular npm major version that committers are saying "upgrade to 7" for (or rather, my reading is "this might happen in 6.x but we won't fix it").
Yep, good idea, #609 is looking pretty anaemic now. |
ee94844
to
4e9caf8
Compare
33be2a4
to
e49684f
Compare
e49684f
to
666d713
Compare
Latest push highlights includes:
|
3dd3500
to
927b0fa
Compare
300418c
to
a119c39
Compare
267ed78
to
b335388
Compare
@colinrotherham this is all working perfectly for me over on this branch, can run every type of test, so whatever I've wrought upon #611 is of my own rebase making and I shall unpick that in the morning! |
E.g. Screenshots aren’t written on error without `./screenshots` directory
We don’t need to publish `preact` as a required dependency and it’s not bundled so we should use `peerDependencies` to specify which versions are supported instead The README says “If you already use Preact in your application” with the example: ``` import preact from 'preact' ```
Migrates WebdriverIO tests away from the deprecated “sync” syntax which both unblocks Node.js 16+ upgrades in future and removes the requirement for a Python build step See: #608
Removes the `copy-webpack-plugin` package since the dev server can proxy `accessible-autocomplete.min.css` from source instead
a45c36a
to
a1accc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have everything a little more up to date, thanks for going through this (and having everything nicely split for review as well). ⛵
Similar to #316 this PR brings all our dependencies up to date
Excluding two major bumps which I've split out:
Note: Updates to Preact have also been excluded since we'll need to update tests separately. For example, we currently require a mismatched Preact version via https://unpkg.com
Configs, tests and polyfills
We know the deprecated
@wdio/sync
package won't install so tests now use async/await insteadBut we can remove more (see below) with config updates, especially now IE 8–10 support is clarified:
core-js@3
polyfillslts/iron
.husky/pre-commit
config formatPackages removed
The following packages were unnecessary or unused:
With more included in
@babel/preset-env
automatically now or to transform to ES3 for Internet Explorer 8:Package audit
See results from
npm audit
belowBefore
After
See PRs #614 and #615 to reach
0 vulnerabilities