Fix binding of handleInputClick
#676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had missed that is was not bound like the other `handleInput...` functions when removing the wrapping arrow function in 25cc4a3. This was displaying an error in the browser console as `this` was not defined when the method was called in response to clicks. That error in the console seems the only effect of the function not being bound. Both with and without input, and with or without the `autoselect` option set, I did not notice any visual change in behaviour from the component. We may want to review the purpose of that event handler, maybe the `handleInputFocus` one does enough? 🤔
romaricpascal
force-pushed
the
bind-input-click
branch
from
7c81bce to
2360f46
Compare
|
Thinking we didn't catch it because we don't have anything failing tests when an error occurs inside the browser 😔 Opened #679 to track adding this as it doesn't seem straightforward. |
domoscargin
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had missed that is was not bound like the other
handleInput...functions when removing the wrapping arrow function in 25cc4a3.This was displaying an error in the browser console as
thiswas not defined when the method was called in response to clicks.That error in the console seems the only effect of the function not being bound. Both with and without input, and with or without the
autoselectoption set, I did not notice any visual change in behaviour from the component.We may want to review the purpose of that event handler, maybe the
handleInputFocusone does enough? 🤔