Skip to content
This repository was archived by the owner on Oct 31, 2019. It is now read-only.

bau: initial commit #1

Merged
merged 4 commits into from
Oct 30, 2017
Merged

bau: initial commit #1

merged 4 commits into from
Oct 30, 2017

Conversation

willp-bl
Copy link
Contributor

@willp-bl willp-bl commented Oct 6, 2017

Pair: WillPa

@annashipman
Copy link
Contributor

I think this is a great idea.

However, I think maybe we should include the contributor code of conduct rather than linking to it as it may require some personalisation. For example, under 'enforcement' it says '[INSERT EMAIL ADDRESS]'.

@willp-bl willp-bl force-pushed the bau/initial_commit branch from 3e30101 to 40a2dde Compare October 6, 2017 14:08
Pair: WillPa
@willp-bl
Copy link
Contributor Author

willp-bl commented Oct 6, 2017

Updated, but still need to add an email address/contact point

@davidillsley
Copy link

Maybe needs some language about the scoping of the Civil Service Code thing eg I don't think it's realistic or desirable to ask non-civil-servant/contracted contributors to be politically impartial outside of the alphagov org

@willp-bl
Copy link
Contributor Author

willp-bl commented Oct 6, 2017

@davidillsley I've added some scoping of the Civil Service Code

@davbo
Copy link

davbo commented Oct 6, 2017

Still needs an email address under enforcement. I'm guessing that shouldn't be a large group of people, perhaps our heads of community ? @rboulton @rjw1 ?

@rboulton
Copy link

rboulton commented Oct 6, 2017

I think the heads of the tech community would be a suitable list; gds-tech-community-lead-members@digital.cabinet-office.gov.uk would be a suitable address to reach this set of people.

@rjw1
Copy link

rjw1 commented Oct 6, 2017

Its that or the github owners list. 

@annashipman
Copy link
Contributor

Can those lists receive emails from outside the digital.cabinet-office org?

@rjw1
Copy link

rjw1 commented Oct 6, 2017

nope. but we could change that.

@annashipman
Copy link
Contributor

I think GitHub owners might be the more suitable one for this, as this is for external contributors contacting us for code of conduct breaches, which may also involve other external contributors, and GitHub owners is the group with the power to block people etc (I think?)

But I don't feel strongly, either would be fine I think.

@timblair
Copy link
Member

timblair commented Oct 6, 2017

The wording of the imported code of conduct talks a lot about a "project": project maintainers, project team, project leadership etc. I don't think this works for our use case, where we're using it as standard for an organisation. The variety of terms (maintainers vs team vs leaders) is also confusing.

I'm also slightly concerned about our ability to actively enforce the CoC in the way stated:

Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.

Hopefully we'd never have to, but given that all maintainers (GitHub owners?) are likely to be GDS employees, it would be a line management thing, not just up to the other maintainers/leaders.

@willp-bl
Copy link
Contributor Author

willp-bl commented Oct 6, 2017

If we clarify that in the context of the code of conduct, "project" means alphagov/GDS that clears up most of the issues you describe. In that case "repercussions" could be dealt with by line management. "maintainers" could translate to tech leads/senior staff.

I would prefer for us to use a off the shelf code of conduct rather than re-inventing or modifying one. That code of conduct is used in quite a lot of places - https://www.contributor-covenant.org/adopters.html

@willp-bl
Copy link
Contributor Author

willp-bl commented Oct 9, 2017

@timblair I've added some context

@annashipman
Copy link
Contributor

I think those changes work and I agree, better to use a recognised one wholesale than modify it.

We still need an email address. GitHub owners?

@maisiefernandes
Copy link

Use this email address disclosure@digital.cabinet-office.gov.uk

@timblair
Copy link
Member

It seems that address is used for responsible disclosure of security issues within Verify's code. Is that right? That's the only reference I can find to it, anyway.

If so, that doesn't feel like the correct channel to be using for enforcement of this CoC. The use-cases are very different, as are the people who'd deal with such things (I'd imagine).

@rjw1
Copy link

rjw1 commented Oct 13, 2017

How about we create alphagov-code-of-conduct@digital.cabinet-office.gov.uk and subscribe gds-github-owners to it.

@rjw1
Copy link

rjw1 commented Oct 17, 2017

The mailing list now exists

@willp-bl
Copy link
Contributor Author

I've added the email address, so this is looking like it is ready to go

Copy link

@rjw1 rjw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@annashipman
Copy link
Contributor

👍

@willp-bl
Copy link
Contributor Author

Anyone want to press merge?

Also, I am considering not deleting this PR + comments when we make this public, any objections?

@annashipman annashipman merged commit 6cd89c3 into master Oct 30, 2017
@annashipman annashipman deleted the bau/initial_commit branch October 30, 2017 12:06
@annashipman
Copy link
Contributor

I have no objections to leaving this PR & comments in place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants