-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Dart Sass from LibSass #3385
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
sass-migrate
branch
from
September 12, 2023 11:35
69d13e0
to
3799e6a
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
from
September 12, 2023 13:29
db17d00
to
861847a
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
from
September 14, 2023 10:54
18a00d2
to
431bc23
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
from
September 14, 2023 10:55
431bc23
to
a951894
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
3 times, most recently
from
September 25, 2023 10:39
6e04e97
to
cfa94c7
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
3 times, most recently
from
September 29, 2023 16:03
9d8b423
to
41b87aa
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
3 times, most recently
from
October 10, 2023 14:22
fea9d60
to
50b2444
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
from
October 11, 2023 10:41
f528368
to
0608d01
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
from
October 11, 2023 13:21
134cffc
to
6d99018
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
from
October 11, 2023 13:32
6d99018
to
805448a
Compare
- Create `dartsass.builds` initializer and add all Sass files to be compiled. See https://github.com/rails/dartsass-rails#configuring-builds - Create .keep - Update manifest file to use /builds directory - Ignore /builds
jon-kirwan
force-pushed
the
sass-migrate
branch
from
November 1, 2023 12:03
805448a
to
3c9f33c
Compare
jon-kirwan
force-pushed
the
sass-migrate
branch
from
November 6, 2023 12:09
3c9f33c
to
27401c6
Compare
Replace instances with CSS url() function. See rails/dartsass-rails#18.
jon-kirwan
force-pushed
the
sass-migrate
branch
from
November 6, 2023 14:19
27401c6
to
2872092
Compare
Closed PR to rename branch. Re-opened here: #3447. |
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrate to Dart Sass from LibSass.
Why
Visual Changes
None.
Anything else
See: