Remove hardcoded banner code #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are no longer required now that UR banners are handled by govuk_web_banners
hannako
force-pushed
the
remove_hardcoded_banner
branch
from
22c766d to
faed86d
Compare
hannako
force-pushed
the
remove_hardcoded_banner
branch
from
faed86d to
f62ca24
Compare
hannako
force-pushed
the
remove_hardcoded_banner
branch
from
f62ca24 to
4eb27ae
Compare
hannako
force-pushed
the
remove_hardcoded_banner
branch
from
4eb27ae to
9598a83
Compare
hannako
force-pushed
the
remove_hardcoded_banner
branch
from
9598a83 to
4b25197
Compare
hannako
force-pushed
the
remove_hardcoded_banner
branch
from
4b25197 to
9444715
Compare
The recommended approach is to add a call to the partial to the application layout below the breadcrumbs[1] However on browse pages, the breadcrumbs sit inside the black browse header so adding the banner across the header looks bad. For browse pages, we need to call the intervention banner partial below the browse header. [1] https://github.com/alphagov/govuk_web_banners?tab=readme-ov-file#adding-recruitment-banners
hannako
force-pushed
the
remove_hardcoded_banner
branch
from
9444715 to
606affc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding UR banners to pages rendered by Collections, this PR
There are no user facing changes
https://trello.com/c/T2PlxBdl/3146-put-live-govuk-user-research-banner-requests-govuk-contact-ukvi