Topic list add branding #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2018
andysellick
force-pushed
the
topic-list-add-branding-and-tracking
branch
from
e1719f4 to
fbcc041
Compare
andysellick
force-pushed
the
topic-list-add-branding-and-tracking
branch
from
fbcc041 to
927d66b
Compare
vanitabarrett
suggested changes
May 11, 2018
| @@ -1,20 +1,22 @@ | |||
| <% | |||
| items ||= [] | |||
| see_more_link ||= false | |||
| size ||= false | |||
| component_size = "app-c-topic-list--small" if size == 'small' | |||
There was a problem hiding this comment.
Would passing in small: true make more sense here? Otherwise people might make typos and/or expect other sizes to be able to be passed in.
There was a problem hiding this comment.
Ha. I came up with both options but thought if I used small: true someone would say why not do a general one for size? But I guess we don't build things that we don't need yet, so I'll take a look.
On the fixup, I think I tried but it didn't work. I'll give it another attempt - I might be thinking of another PR.
There was a problem hiding this comment.
@vanitabarrett I can't fixup that commit - I must have changed something that means the commits can't be reordered. Have addressed the other point though.
- improve code reuse in tests
andysellick
force-pushed
the
topic-list-add-branding-and-tracking
branch
from
927d66b to
4b34fc0
Compare
vanitabarrett
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add colour branding and a 'small' option to the topic list component.
Component guide: https://govuk-collections-pr-651.herokuapp.com/component-guide/topic-list
Trello card: https://trello.com/c/SvSNQlsa/50-modify-component-list-of-links-topic-list