Add autocomplete to search index #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intend to use the conditional for which search component we use in two places now: the search results page and the search entry form. To facilitate this without requiring code to be copied I have moved the logic for this into a helper method.
I intend to add a conditional to the index action of SearchController and I want to test it. When I went to implement this I noticed there were not any specs for the action so I thought adding some basic tests would be appropriate.
kevindew
force-pushed
the
show-autocomplete-on-search
branch
from
7434f92 to
4483a87
Compare
We've tried to add autocomplete to each site search input on GOV.UK. When reviewing this we noticed that one of them was missed, the one on https://www.gov.uk/search. This commit corrects this by adding the component here.
kevindew
force-pushed
the
show-autocomplete-on-search
branch
from
4483a87 to
4d75152
Compare
jackbot
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tried to add autocomplete to each site search input on GOV.UK. When reviewing this we noticed that one of them was missed, the one on https://www.gov.uk/search.
This PR corrects this by adding it to this page, with the first two commits doing foundational work for this change. More info in the commits.