Remove use of shared helper for margin #3611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes the shared helper call to set margin, as this is now handled by the component wrapper helper, which all of these components already use - one of these didn't seem to be using the shared helper at all
andysellick
force-pushed
the
remove-shared-helper-margin
branch
from
fa2a8ae to
8900957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
The component wrapper helper now handles margin bottom in the same way that the shared helper does, but automatically, so only a default needs to be set. In the case of these components their default behaviour is for no bottom margin, which is the default behaviour for the wrapper anyway, so doesn't need to be set.
Visual changes
None, hopefully.
Trello card: https://trello.com/c/Y0pDWbHw/390-move-some-shared-helper-options-into-component-wrapper?filter=member:andysellick2