Change all title components to heading components #3647
Conversation
| @@ -7,7 +7,6 @@ | |||
| heading_level: 1, | |||
| font_size: "xl", | |||
| margin_bottom: 4, | |||
| inverse: inverse, | |||
There was a problem hiding this comment.
Sorry, just noticed this - what was this change for?
There was a problem hiding this comment.
I couldn't replicate a view where there is an inverse header, so I thought it was an error.
There was a problem hiding this comment.
I think I'd be more comfortable with this change supported by some more investigation. Since this is unrelated I suggest not deleting this line as part of this PR.
There was a problem hiding this comment.
OK I've reverted that and also the other two titles further down the page where I'd also removed the inverse option.
There was a problem hiding this comment.
Great, thanks. I've spotted an unrelated problem with this app but I'd like to get your changes out first, I know you've just finished for today so apologies am going to merge this PR (if I can get the tests to pass).
matthillco
force-pushed
the
titles-to-headings
branch
from
909308d to
79c6b42
Compare
Note that indentation of the main content changes on the index but this doesn't materially change anything.
andysellick
force-pushed
the
titles-to-headings
branch
from
79c6b42 to
208b079
Compare
What
Replace title components with headings. This PR covers the following views:
Why
We are attempting to retire the page title component in favour of the heading component. Trello
Before and After views:
Changes are minor and acceptable according to our criteria.