Pass safe HTML to the search component #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test for the vulnerability fixed in #480. I've confirmed that the test works by removing the `sanitize` call from the offending string (https://github.com/alphagov/finder-frontend/blob/4012a62f70b84ce70b55fc f4b312b0f87e2478cb/app/views/search/_search_field.html.erb#L3).
After alphagov/govuk_publishing_components#283 it's no longer possible to pass unsafe HTML to the search component. By using `capture` we use Rails' escaping and sanitisation mechanism to sanitise `@search_term` and any other use input.
boffbowsh
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After alphagov/govuk_publishing_components#283 it's no longer possible to pass unsafe HTML to the search component. By using
capturewe use Rails' escaping and sanitisation mechanism to sanitise@search_termand any other user input.Also adds a test for the vulnerability fixed in #480.