Start save location on cookie consent #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
approved these changes
May 10, 2021
andysellick
force-pushed
the
save-location-cookie-consent
branch
from
3604f29 to
070845f
Compare
|
This is probably more related to the supporting gem PR alphagov/govuk_publishing_components#2041 but since that PR's been closed I will leave it here. |
|
Have opened alphagov/govuk_publishing_components#2079 to try and fix the error I outlined in my earlier comment. |
- save location on bank holidays page checks for cookie consent first - if it finds it, execution continues normally - if it doesn't, it sets up an event listener to continue normally when cookies are consented - this means that if a user consents to cookies on the bank holidays page, the save location functionality now appears immediately, instead of requiring a page refresh
andysellick
force-pushed
the
save-location-cookie-consent
branch
from
070845f to
686974c
Compare
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE - relies upon a new version of the gem with alphagov/govuk_publishing_components#2041 firstDone and rebased
What / why
Updates the save location bank holidays experiment code so that if users consent to cookies on that page, the functionality immediately appears. Before, it wouldn't appear unless users refreshed the page, because it depended on cookie consent to work.
Visual changes
None, but you can test that it works properly by loading up the
/bank-holidayspage, clearing cookies and reloading. The cookie banner should be present, the save location option not. Consenting to cookies should cause the save location option to immediately appear.Trello card: https://trello.com/c/QweAgiPc/693-bank-holidays-experiment-things-to-clean-up