Help page document #4250
Merged
Help page document #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georges1996
force-pushed
the
move-help-page
branch
from
0561d66 to
0549030
Compare
georges1996
force-pushed
the
move-help-page
branch
from
db9e7e2 to
1e1bbbc
Compare
georges1996
force-pushed
the
move-help-page
branch
from
1e1bbbc to
7edf0d3
Compare
leenagupte
reviewed
Oct 9, 2024
There was a problem hiding this comment.
This is a really good start. I think not being able to merge the Take Part PR means that this one needs some extra work before it's ready.
We've already spoken IRL about linking to the files in government-frontend directly. I think the only commit that needs the links updated is the one that ports over the components.
I've added inline comments for everything else.
georges1996
force-pushed
the
move-help-page
branch
from
7edf0d3 to
7e13108
Compare
georges1996
force-pushed
the
move-help-page
branch
from
7e13108 to
680318a
Compare
georges1996
force-pushed
the
move-help-page
branch
from
680318a to
0a19583
Compare
georges1996
force-pushed
the
move-help-page
branch
from
0a19583 to
1cb231d
Compare
georges1996
force-pushed
the
move-help-page
branch
from
3d10363 to
a1bec0a
Compare
georges1996
force-pushed
the
move-help-page
branch
from
a1bec0a to
8899bce
Compare
georges1996
force-pushed
the
move-help-page
branch
from
8899bce to
a254b1d
Compare
georges1996
force-pushed
the
move-help-page
branch
from
a254b1d to
18f8587
Compare
georges1996
force-pushed
the
move-help-page
branch
from
18f8587 to
51b5458
Compare
georges1996
force-pushed
the
move-help-page
branch
from
023eac4 to
43a048b
Compare
georges1996
force-pushed
the
move-help-page
branch
from
43a048b to
67813dd
Compare
georges1996
force-pushed
the
move-help-page
branch
from
67813dd to
099f933
Compare
georges1996
force-pushed
the
move-help-page
branch
from
099f933 to
985c869
Compare
georges1996
force-pushed
the
move-help-page
branch
from
985c869 to
717cebb
Compare
KludgeKML
approved these changes
Oct 17, 2024
leenagupte
reviewed
Oct 23, 2024
georges1996
force-pushed
the
move-help-page
branch
from
717cebb to
1e8b0a4
Compare
georges1996
force-pushed
the
move-help-page
branch
from
1e8b0a4 to
df5475b
Compare
Commit audit trail: - app/views/shared/_footer_navigation.html.erb https://github.com/alphagov/government-frontend/blob/3e5710c5129b3e1b1abd7176fef951bc73b7b49b/app/views/shared/_footer_navigation.html.erb - app/views/shared/_sidebar_navigation.html.erb https://github.com/alphagov/government-frontend/blob/3e5710c5129b3e1b1abd7176fef951bc73b7b49b/app/views/shared/_sidebar_navigation.html.erb
- Used in Help Page - Includes spec file, documentation Commit audit trail: - app/assets/stylesheets/components/_published-dates.scss https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/app/assets/stylesheets/components/_published-dates.scss - app/views/components/_published_dates.html.erb https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/app/views/components/_published_dates.html.erb - app/views/components/docs/published_dates.yml https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/app/views/components/docs/published_dates.yml - spec/components/published_dates_spec.rb https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/test/components/published_dates_test.rb
- Ran rake "consolidation:copy_translation[components.published_dates]"
…p_page - Add new route - Add help_page controller - Add body_with_related_links partial - Update content item model - Add help_page views - Add system spec for the new help_page Commit audit trail: - spec/system/help_page_spec.rb https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/test/integration/help_page_test.rb - app/views/help_page/show.html.erb https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/app/views/content_items/help_page.html.erb - app/views/content_items/_body_with_related_links.html.erb https://github.com/alphagov/government-frontend/blob/3e5710c5129b3e1b1abd7176fef951bc73b7b49b/app/views/content_items/_body_with_related_links.html.erb
- Add new DateHelper to deal with the last updated date on help pages - Add page_text_direction to LocaleHelper Commit audit trail: - app/helpers/locale_helper.rb https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/app/helpers/application_helper.rb - app/helpers/date_helper.rb https://github.com/alphagov/government-frontend/blob/af54031948650448b965ac274c3248d23658c4f6/app/presenters/content_item_presenter.rb
- Ran rake "rake "consolidation:copy_translation[i18n]"
georges1996
force-pushed
the
move-help-page
branch
from
df5475b to
cc4a20f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Handle Help page documents in Frontend, in preparation for them being taken out of Government Frontend
Why
https://trello.com/c/GP0bkcD4/350-move-document-type-helppage-from-government-frontend-to-frontend
How
These documents all have a fixed prefix, so add a scoped route for them, a controller, a model and a view. Here we add the initial ContentItem model the document type models will be based on, with the minimum functionality required to get Help page documents working.
We also create a couple of helpers for rendering generic content.
Screenshots?
From example page: https://www.gov.uk/help/browsers
Before (running in Government Frontend)
After (running in Frontend)