Fix issues with charts and card blocks #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
force-pushed
the
fix-graphs
branch
from
e698aa3 to
845b15b
Compare
- graphs were being made short everywhere, but should only be short when the minimal option is used, when the graph is in a three column layout
- make the whole row flexbox to avoid mixing grid and flexbox - set background colour of the cards to dark blue, and the chart to white, to make the heading look like it's filling the available vertical space - add min-width 0 to the cards to fix the graph not resizing problem - improve test data
leenagupte
force-pushed
the
fix-graphs
branch
from
845b15b to
00704ea
Compare
leenagupte
force-pushed
the
fix-graphs
branch
from
00704ea to
62c4b95
Compare
- assuming that a card always has a heading link - so easier to split it out as specific attributes than treat it as a subblock, because then we can modify it - introduce the link_cover_block option, which sets the link class to include a pseudo element that covers the whole card in a single link, removing the need to make minimal charts a link and avoiding having duplicate links - update the YAML and tests accordingly Co-authored-by: Andy Sellick <andy.sellick@digital.cabinet-office.gov.uk>
- makes the padding left/right on the card block match the same padding in the hero block text box, as they're both blue boxes with white text
- bring the text around charts in a bit, as they're currently colliding with the edge of their containing element when shown inside a card block - this option at time of writing isn't available, will be added in alphagov/govuk_publishing_components#4342
leenagupte
force-pushed
the
fix-graphs
branch
from
62c4b95 to
f8b3ec7
Compare
- needed to make the charts work again, currently erroring without the minimal link
|
@leenagupte have bumped the gem so the preview works again. I've visually checked the pages and all my changes seem to be fine, so good to review 👍 |
leenagupte
reviewed
Oct 25, 2024
matthillco
approved these changes
Oct 25, 2024
| display: grid; | ||
| grid-template-columns: repeat(3, 1fr); | ||
| display: flex; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
Curious why this changed from grid to flex? It works fine so I'm happy to approve, just curious.
There was a problem hiding this comment.
Good question. I initially changed it as part of investigating the problem with chart resizing. When I realised that it was equivalent I thought it might be better to keep it all as flexbox, just to avoid mixing the two.
There was a problem hiding this comment.
Thanks for the review 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix a variety of issues to do with the charts. Commits:
Why
Arising from design and accessibility reviews.
Visual changes
Fixing the height issue on
/landing-page/tasksFixing the resizing problem:
Refactoring to change from two links to one (hard to tell from the screenshots, easier if you just try it out)
Fixing the padding on the blue bit of the card block (it's the indentation of the 'Be kinder' heading - the change to the contents list is because I took this screenshot before rebasing)
Enable padding on the charts - note the change on the 'data table' and 'download chart data' links (dependent on a new gem version containing alphagov/govuk_publishing_components#4342)
Trello card: https://trello.com/c/VKrLuGvg