-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata block #4392
base: main
Are you sure you want to change the base?
Add metadata block #4392
Conversation
f130889
to
4f2a886
Compare
4f2a886
to
6b68312
Compare
6b68312
to
0702e9c
Compare
0702e9c
to
17f8548
Compare
98221f1
to
bf85208
Compare
bf85208
to
df685e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, my only question is should this be a block that we need to remember to add, or should it be built into the page template somehow?
Thanks @andysellick Probably, but I think that would require some backend work - should I get one of the backend devs to help with this card? |
@AshGDS I'm prepared to be wrong on this one, so maybe just start with a chat with a BE dev and see what they think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now but may find a different solution later.
1e72a4f
to
3498784
Compare
What / Why
metadata
block for the landing pagetitle
anddescription
from the content item by default, but these can be overridden in theyml
body.Screenshots