Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata block #4392

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add metadata block #4392

wants to merge 3 commits into from

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Nov 13, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What / Why

  • Adds a metadata block for the landing page
  • These meta tags make social share previews look better
  • It grabs the title and description from the content item by default, but these can be overridden in the yml body.
  • You can use the Social share preview plugin to see how it will look to users
  • The Machine readable data component crashes when I import it into PfG, and doesn't allow featured image customisation, so I've just added the metatags using a block. We've done similar for the GOVUK Roadmap
  • Trello card

Screenshots

image

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 13:45 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 14:24 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 14:35 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 15:30 Inactive
@AshGDS AshGDS changed the title [WIP] metadata block Add metadata block Nov 13, 2024
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 16:02 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 16:05 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 16:34 Inactive
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 13, 2024 16:39 Inactive
@AshGDS AshGDS marked this pull request as ready for review November 13, 2024 16:41
@AshGDS AshGDS self-assigned this Nov 14, 2024
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, my only question is should this be a block that we need to remember to add, or should it be built into the page template somehow?

@AshGDS
Copy link
Contributor Author

AshGDS commented Nov 14, 2024

Thanks @andysellick Probably, but I think that would require some backend work - should I get one of the backend devs to help with this card?

@andysellick
Copy link
Contributor

@AshGDS I'm prepared to be wrong on this one, so maybe just start with a chat with a BE dev and see what they think.

Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now but may find a different solution later.

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4392 November 14, 2024 14:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants