Use component wrapper in published dates component #4543
Merged
+43
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify the published dates component to use the component wrapper helper - move the visibly hidden heading inside the component and adjust a test accordingly
andysellick
force-pushed
the
published-dates
branch
from
30888f4 to
7795d1b
Compare
This was referenced Dec 18, 2024
andysellick
changed the title
MartinJJones
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
This component was using the shared helper for margin bottom but this functionality is being moved to the component wrapper helper.
Visual changes
None.
Trello card: https://trello.com/c/qH4NyWJw/364-add-component-wrapper-to-more-components