Add support for local_authority_slug disambiguator for Imminence places endpoint #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
imminence-additional-parameters
branch
from
62563c1 to
0dcd831
Compare
KludgeKML
force-pushed
the
imminence-additional-parameters
branch
from
ad0171f to
c0542d9
Compare
1pretz1
reviewed
Feb 15, 2023
…es endpoint, remove preprocessing of imminence responses Breaking change which allows more complex responses by removing preprocessing code. Also remove obsolete location handling code, and update pact tests to include address disambiguation response.
KludgeKML
force-pushed
the
imminence-additional-parameters
branch
from
c0542d9 to
6dd1ee0
Compare
1pretz1
approved these changes
Feb 15, 2023
|
Note for posterity: Failing pacts tests will be addressed in Imminence merge coming soon in this PR: alphagov/places-manager#862 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support split postcode disambiguation for places items in Frontend, Imminence's place endpoint has to be able to take a local authority slug in addition to a postcode.
https://trello.com/c/C4nLJyVO/1778-add-split-postcode-support-for-places-in-frontend