Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename embedded endpoint and associated method #1298

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

pezholio
Copy link
Contributor

@pezholio pezholio commented Nov 26, 2024

We’ve renamed the endpoint to get host content for a content ID to better reflect what it does. This updates the method to call the new endpoint (we will soon retire the old one). To ensure backward compatility, we alias the method too and output a warning.

@pezholio pezholio force-pushed the content-modelling/call-embedded-endpoint branch 3 times, most recently from 63c80c3 to 22013b1 Compare November 26, 2024 11:38
@pezholio pezholio marked this pull request as ready for review November 26, 2024 11:43
@pezholio pezholio force-pushed the content-modelling/call-embedded-endpoint branch from 22013b1 to 2f6ce5b Compare November 26, 2024 12:01
We’ve renamed the endpoint to get host content for a content ID to
better reflect what it does. This updates the method to call the new
endpoint (we will soon retire the old one). To ensure backward
compatility, we alias the method too.
@pezholio pezholio force-pushed the content-modelling/call-embedded-endpoint branch from 2f6ce5b to f069f3c Compare November 26, 2024 12:02
@pezholio pezholio merged commit 5d9845e into main Nov 26, 2024
41 checks passed
@pezholio pezholio deleted the content-modelling/call-embedded-endpoint branch November 26, 2024 12:09
pezholio added a commit that referenced this pull request Nov 26, 2024
* Update dependencies
* Rename `get_content_by_embedded_document` and call renamed endpoint [PR](#1298)
@pezholio pezholio mentioned this pull request Nov 26, 2024
pezholio added a commit that referenced this pull request Nov 26, 2024
* Update dependencies
* Rename `get_content_by_embedded_document` and call renamed endpoint [PR](#1298)
pezholio added a commit that referenced this pull request Nov 28, 2024
This endpoint is now deprecated (See #1298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants