Release 98.0.0 #1311
Merged
Release 98.0.0 #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pezholio
commented
Dec 17, 2024
•
pezholio
commented
- Remove Router API methods PR
- Add a method to get events for a Content ID PR
brucebolt
reviewed
Dec 17, 2024
CHANGELOG.md
Outdated
| @@ -1,8 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
| ## 97.7.0 | |||
|
|
|||
| * Remove router-api [PR](https://github.com/alphagov/gds-api-adapters/pull/1308) | |||
There was a problem hiding this comment.
This appears to be a breaking change (although wasn't labelled as such when added).
Could you add BREAKING: as a prefix to this line and release version 98.0.0 instead?
I'd also suggest rewording it to Remove Router API methods.
(I know you didn't add this change, but it appears to have not been reviewed by our team at the time)
There was a problem hiding this comment.
Oh good point! Have fixed
pezholio
force-pushed
the
release-97.7.0
branch
from
daa64d3 to
21adc0d
Compare
pezholio
force-pushed
the
release-97.7.0
branch
from
21adc0d to
d143d62
Compare
pezholio
force-pushed
the
release-97.7.0
branch
from
d143d62 to
c2368ea
Compare
brucebolt
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.