Add collections to publisher metadata if B variant

alphagov · Aug 15, 2018 · 2fb963f · 2fb963f
1 parent a3a949f
commit 2fb963f
Show file tree

Hide file tree

Showing 6 changed files with 67 additions and 9 deletions.
diff --git a/app/controllers/content_items_controller.rb b/app/controllers/content_items_controller.rb
@@ -61,6 +61,7 @@ def set_guide_draft_access_token
   def load_content_item
     content_item = Services.content_store.content_item(content_item_path)
     @content_item = PresenterBuilder.new(content_item, content_item_path).presenter
+    @content_item.include_collections_in_other_publisher_metadata = show_new_navigation?
   end
 
   def load_taxonomy_navigation

diff --git a/app/presenters/content_item/metadata.rb b/app/presenters/content_item/metadata.rb
@@ -20,14 +20,18 @@ def important_metadata
     end
 
     def publisher_metadata
-      {
-        published: published,
-        last_updated: updated,
-        link_to_history: !!updated,
-        other: {
-          'From': from
+      {}.tap do |publisher_metadata|
+        publisher_metadata[:published] = published
+        publisher_metadata[:last_updated] = updated
+        publisher_metadata[:link_to_history] = !!updated
+        publisher_metadata[:other] = {
+          from: from,
         }
-      }
+
+        if include_collections_in_other_publisher_metadata
+          publisher_metadata[:other][:collections] = links('document_collections')
+        end
+      end
     end
   end
 end
diff --git a/app/presenters/content_item_presenter.rb b/app/presenters/content_item_presenter.rb
@@ -14,6 +14,8 @@ class ContentItemPresenter
               :document_type,
               :taxons
 
+  attr_accessor :include_collections_in_other_publisher_metadata
+
   def initialize(content_item, requested_content_item_path = nil)
     @content_item = content_item
     @requested_content_item_path = requested_content_item_path

diff --git a/app/views/components/_publisher-metadata.html.erb b/app/views/components/_publisher-metadata.html.erb
@@ -16,10 +16,33 @@
           <%
             values ||= []
             values = Array(values)
+            toggle_id = "app-c-publisher-metadata__definition--#{title.to_s.parameterize(separator: '-')}"
           %>
           <% if values.any? %>
-            <dt class="app-c-publisher-metadata__term"><%= title %>: </dt>
-            <dd class="app-c-publisher-metadata__definition"><%= values.to_sentence.html_safe %></dd>
+            <dt class="app-c-publisher-metadata__term">
+              <%= t(title.to_s.parameterize(separator: '_'),
+                    scope: 'components.publisher_metadata',
+                    default: title.to_s.humanize) %>:
+            </dt>
+            <dd class="app-c-publisher-metadata__definition" data-module="gem-toggle">
+              <% if title == :collections %>
+                <% if values.size <= 2 %>
+                  <%= values.take(2).to_sentence.html_safe %>
+                <% else %>
+                  <% featured_values, *other_values = values %>
+                  <%= featured_values %> and <%= pluralize(other_values.size, 'other') %>
+                  <a href="#"
+                     data-controls="<%= toggle_id %>"
+                     data-expanded="false"
+                     data-toggled-text="&minus; <%= t('components.publisher_metadata.hide_all') %>">
+                    + <%= t('components.publisher_metadata.show_all') %>
+                  </a>
+                  <span id="<%= toggle_id %>" class="js-hidden"><%= other_values.to_sentence.html_safe %></span>
+                <% end %>
+              <% else %>
+                <%= values.to_sentence.html_safe %>
+              <% end %>
+            </dd>
           <% end %>
         <% end %>
         </dl>

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -26,6 +26,11 @@ en:
   common:
     last_updated: "Last updated"
   components:
+    publisher_metadata:
+      from: "From"
+      collections: "Collections"
+      show_all: "show all"
+      hide_all: "hide all"
     related_navigation:
       collections: "Collection"
       external_links: "Elsewhere on the web"

diff --git a/test/integration/content_pages_related_navigation_test.rb b/test/integration/content_pages_related_navigation_test.rb
@@ -35,6 +35,29 @@ def setup
     refute page.has_css?('.gem-c-related-navigation__sub-heading', text: 'Collection')
   end
 
+  test "ContentPagesNav variant A does not show collections as publisher metadata" do
+    stub_rummager
+    setup_variant_a
+
+    setup_and_visit_content_item_with_taxons('case_study', SINGLE_TAXON)
+
+    within '.app-c-publisher-metadata' do
+      refute page.has_css?('.app-c-publisher-metadata__term', text: 'Collections')
+    end
+  end
+
+  test "ContentPagesNav variant B shows collections as publisher metadata" do
+    stub_rummager
+    setup_variant_b
+
+    setup_and_visit_content_item_with_taxons('case_study', SINGLE_TAXON)
+
+    within '.app-c-publisher-metadata' do
+      assert page.has_css?('.app-c-publisher-metadata__term', text: 'Collections')
+      assert page.has_css?('.app-c-publisher-metadata__definition a', text: 'Work Programme real life stories')
+    end
+  end
+
   def setup_variant_a
     ContentItemsController.any_instance.stubs(:show_new_navigation?).returns(false)
   end