Skip to content

Commit

Permalink
Remove the phantom gem, the only thing this does is download a binary
Browse files Browse the repository at this point in the history
this gem is not official as far as i can tell,
and only downloads a binary, instead list as a
dependency in the readme, and leave it as an excercise
to the reader/vm to have phantomjs
  • Loading branch information
Andrew Hilton committed Apr 11, 2017
1 parent d00c03c commit 4cafaf7
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,4 @@ group :test do
gem 'govuk-content-schema-test-helpers', '1.1.0'
gem 'mocha'
gem 'poltergeist', require: false
gem 'phantomjs'
end
3 changes: 1 addition & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ DEPENDENCIES
jasmine-rails (~> 0.14.0)
logstasher (= 0.6.1)
mocha
phantomjs
plek (= 1.11)
poltergeist
pry-byebug
Expand All @@ -293,4 +292,4 @@ RUBY VERSION
ruby 2.3.1p112

BUNDLED WITH
1.14.5
1.14.6
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ This is a Ruby on Rails application that fetches documents from

- [content-store](https://github.com/alphagov/content-store) - provides documents
- [static](https://github.com/alphagov/static) - provides shared GOV.UK assets and templates.
- [phantomjs](http://phantomjs.org/) Used by poltergeist for integration testing

### Running the application

Expand Down

0 comments on commit 4cafaf7

Please sign in to comment.