Add tasklist header A/B test to secondary pages

The tasklist header also needs to be shown on secondary pages that are part of the A/B test. Some refactoring has been done to improve dependency issues.
alphagov · Nov 9, 2017 · 7c466a2 · 7c466a2
1 parent 62159b3
commit 7c466a2
Show file tree

Hide file tree

Showing 3 changed files with 83 additions and 76 deletions.
diff --git a/app/controllers/concerns/tasklist_ab_testable.rb b/app/controllers/concerns/tasklist_ab_testable.rb
@@ -1,78 +1,6 @@
 module TasklistABTestable
   TASKLIST_DIMENSION = 66
 
-  TASKLIST_PRIMARY_PAGES = %w(
-    /apply-first-provisional-driving-licence
-    /book-driving-test
-    /book-theory-test
-    /cancel-driving-test
-    /cancel-theory-test
-    /change-driving-test
-    /change-theory-test
-    /check-driving-test
-    /check-theory-test
-    /driving-eyesight-rules
-    /driving-lessons-learning-to-drive
-    /driving-test/what-to-take
-    /find-driving-schools-and-lessons
-    /government/publications/car-show-me-tell-me-vehicle-safety-questions
-    /guidance/the-highway-code
-    /legal-obligations-drivers-riders
-    /pass-plus
-    /take-practice-theory-test
-    /theory-test/revision-and-practice
-    /theory-test/what-to-take
-    /vehicles-can-drive
-  ).freeze
-
-  TASKLIST_SECONDARY_PAGES = %w(
-    /apply-for-your-full-driving-licence
-    /automatic-driving-licence-to-manual
-    /complain-about-a-driving-instructor
-    /driving-licence-fees
-    /driving-test-cost
-    /dvlaforms
-    /find-theory-test-pass-number
-    /government/publications/application-for-refunding-out-of-pocket-expenses
-    /government/publications/drivers-record-for-learner-drivers
-    /government/publications/driving-instructor-grades-explained
-    /government/publications/know-your-traffic-signs
-    /government/publications/l-plate-size-rules
-    /guidance/rules-for-observing-driving-tests
-    /report-an-illegal-driving-instructor
-    /report-driving-medical-condition
-    /report-driving-test-impersonation
-    /seat-belts-law
-    /speed-limits
-    /track-your-driving-licence-application
-    /vehicle-insurance
-    /view-driving-licence
-  ).freeze
-
-  MATCHING_PAGES = %w(
-    /driving-lessons-learning-to-drive/practising-with-family-or-friends
-    /driving-lessons-learning-to-drive/taking-driving-lessons
-    /driving-lessons-learning-to-drive/using-l-and-p-plates
-    /driving-test
-    /driving-test/changes-december-2017
-    /driving-test/disability-health-condition-or-learning-difficulty
-    /driving-test/driving-test-faults-result
-    /driving-test/test-cancelled-bad-weather
-    /driving-test/using-your-own-car
-    /driving-test/what-happens-during-test
-    /pass-plus/apply-for-a-pass-plus-certificate
-    /pass-plus/booking-pass-plus
-    /pass-plus/car-insurance-discounts
-    /pass-plus/local-councils-offering-discounts
-    /pass-plus/how-pass-plus-training-works
-    /theory-test
-    /theory-test/hazard-perception-test
-    /theory-test/if-you-have-safe-road-user-award
-    /theory-test/multiple-choice-questions
-    /theory-test/pass-mark-and-result
-    /theory-test/reading-difficulty-disability-or-health-condition
-  ).freeze
-
   def self.included(base)
     base.helper_method(
       :tasklist_variant,
@@ -109,8 +37,8 @@ def set_tasklist_response_header
   end
 
   def page_is_included_in_test?
-    TASKLIST_PRIMARY_PAGES.include?(request.path) ||
-      TASKLIST_SECONDARY_PAGES.include?(request.path) ||
-      MATCHING_PAGES.include?(request.path)
+    TasklistPages::PRIMARY_PAGES.include?(request.path) ||
+      TasklistPages::SECONDARY_PAGES.include?(request.path) ||
+      TasklistPages::MATCHING_PAGES.include?(request.path)
   end
 end
diff --git a/app/controllers/concerns/tasklist_header_ab_testable.rb b/app/controllers/concerns/tasklist_header_ab_testable.rb
@@ -20,7 +20,7 @@ def tasklist_header_ab_test
   end
 
   def tasklist_header_ab_test_applies?
-    TasklistABTestable::TASKLIST_PRIMARY_PAGES.include?(request.path)
+    page_is_included_in_test?
   end
 
   def should_show_tasklist_header?
@@ -35,4 +35,10 @@ def tasklist_header_variant
   def set_tasklist_header_response_header
     tasklist_header_variant.configure_response(response) if tasklist_header_ab_test_applies?
   end
+
+  def page_is_included_in_test?
+    TasklistPages::PRIMARY_PAGES.include?(request.path) ||
+      TasklistPages::SECONDARY_PAGES.include?(request.path) ||
+      TasklistPages::MATCHING_PAGES.include?(request.path)
+  end
 end
diff --git a/app/controllers/concerns/tasklist_pages.rb b/app/controllers/concerns/tasklist_pages.rb
@@ -0,0 +1,73 @@
+module TasklistPages
+  PRIMARY_PAGES = %w(
+    /apply-first-provisional-driving-licence
+    /book-driving-test
+    /book-theory-test
+    /cancel-driving-test
+    /cancel-theory-test
+    /change-driving-test
+    /change-theory-test
+    /check-driving-test
+    /check-theory-test
+    /driving-eyesight-rules
+    /driving-lessons-learning-to-drive
+    /driving-test/what-to-take
+    /find-driving-schools-and-lessons
+    /government/publications/car-show-me-tell-me-vehicle-safety-questions
+    /guidance/the-highway-code
+    /legal-obligations-drivers-riders
+    /pass-plus
+    /take-practice-theory-test
+    /theory-test/revision-and-practice
+    /theory-test/what-to-take
+    /vehicles-can-drive
+  ).freeze
+
+  SECONDARY_PAGES = %w(
+    /apply-for-your-full-driving-licence
+    /automatic-driving-licence-to-manual
+    /complain-about-a-driving-instructor
+    /driving-licence-fees
+    /driving-test-cost
+    /dvlaforms
+    /find-theory-test-pass-number
+    /government/publications/application-for-refunding-out-of-pocket-expenses
+    /government/publications/drivers-record-for-learner-drivers
+    /government/publications/driving-instructor-grades-explained
+    /government/publications/know-your-traffic-signs
+    /government/publications/l-plate-size-rules
+    /guidance/rules-for-observing-driving-tests
+    /report-an-illegal-driving-instructor
+    /report-driving-medical-condition
+    /report-driving-test-impersonation
+    /seat-belts-law
+    /speed-limits
+    /track-your-driving-licence-application
+    /vehicle-insurance
+    /view-driving-licence
+  ).freeze
+
+  MATCHING_PAGES = %w(
+    /driving-lessons-learning-to-drive/practising-with-family-or-friends
+    /driving-lessons-learning-to-drive/taking-driving-lessons
+    /driving-lessons-learning-to-drive/using-l-and-p-plates
+    /driving-test
+    /driving-test/changes-december-2017
+    /driving-test/disability-health-condition-or-learning-difficulty
+    /driving-test/driving-test-faults-result
+    /driving-test/test-cancelled-bad-weather
+    /driving-test/using-your-own-car
+    /driving-test/what-happens-during-test
+    /pass-plus/apply-for-a-pass-plus-certificate
+    /pass-plus/booking-pass-plus
+    /pass-plus/car-insurance-discounts
+    /pass-plus/local-councils-offering-discounts
+    /pass-plus/how-pass-plus-training-works
+    /theory-test
+    /theory-test/hazard-perception-test
+    /theory-test/if-you-have-safe-road-user-award
+    /theory-test/multiple-choice-questions
+    /theory-test/pass-mark-and-result
+    /theory-test/reading-difficulty-disability-or-health-condition
+  ).freeze
+end