Add lang attribute to withdrawal notice #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
force-pushed
the
withdrawn-notice-lang
branch
from
31346a5 to
b72e30c
Compare
maxgds
force-pushed
the
withdrawn-notice-lang
branch
from
b72e30c to
ad18506
Compare
owenatgov
reviewed
Sep 15, 2020
| @@ -9,11 +9,13 @@ def page_title | |||
| end | |||
|
|
|||
| def withdrawal_notice_component | |||
| lang = I18n.locale.to_s == "en" ? false : "en" | |||
There was a problem hiding this comment.
One little code nitpick. As this variable is only used once, could this ternary operator be moved to the lang attribute below instead of being passed via this variable?
Withdrawal notices are always presented in English but sometimes appear on a translated page. This passes en as a language value to the notice component when that happens.
maxgds
force-pushed
the
withdrawn-notice-lang
branch
from
ad18506 to
2aee254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/k5JCHIoZ/382-add-language-attribute-to-withdrawn-banner
Withdrawal notices are always presented in English but sometimes
appear on a translated page. This passes en as a language value to
the notice component when that happens.
Example page: https://www.gov.uk/government/news/changes-to-uk-visa-application-process-in-germany.de
There are no visual changes. The effects of this won't be seen until the notice component supports the lang attribute which will happen in a forthcoming release (see alphagov/govuk_publishing_components#1686) but there are no ill effects from passing the extra parameter.
Merged changes are automatically deployed to staging and production.
Make sure you follow the guidance for deployments before you merge.
Check your branch is being deployed in the Release app, after merging.