Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show breadcrumbs consistently #238

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Show breadcrumbs consistently #238

merged 1 commit into from
Jan 25, 2017

Conversation

tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Jan 25, 2017

Currently we don't show the breadcrumbs if the format traditionally doesn't have them.

On other pages on GOV.UK we've introduced the breadcrumbs, whether or not they're set. For example, https://www.gov.uk/aaib-reports just has a "Home" breadcrumb, because
https://www.gov.uk/aaib-reports/aaib-investigation-to-airbus-a319-111-g-ezfj has a breadcrumb to that page.

This adds consistent breadcrumbs to all pages. This means that we'll show empty "Home" breadcrumbs for fatality notices, statistics announcements, statistical data sets, "take part" pages and groups. Note that it's super easy to set the breadcrumb for these pages, by adding a parent link to the presenter in Whitehall.

This should make #237 a little easier.

@NickColley @fofr thoughts?

Examples

before after
screen shot 2017-01-25 at 12 41 11 screen shot 2017-01-25 at 12 41 23
screen shot 2017-01-25 at 12 41 27 screen shot 2017-01-25 at 12 41 40

Currently we don't show the breadcrumbs if the format traditionally
doesn't have them.

On other pages on GOV.UK we've introduced the breadcrumbs, whether or
not they're set. For example, https://www.gov.uk/aaib-reports just has
a "Home" breadcrumb, because
https://www.gov.uk/aaib-reports/aaib-investigation-to-airbus-a319-111-g-
ezfj has a breadcrumb to that page.

This adds consistent breadcrumbs to all pages. This means that we'll
show empty "Home" breadcrumbs for fatality notices, statistics
announcements, statistical data sets, "take part" pages and groups.
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-238 January 25, 2017 12:49 Inactive
@tijmenb tijmenb mentioned this pull request Jan 25, 2017
@fofr
Copy link
Contributor

fofr commented Jan 25, 2017

👍 to the simplification

However, is this useful to users? It looks like we're pushing the content down further and adding a duplicate link (ie Home is the same as clicking on the GOV.UK logo).

@NickColley
Copy link
Contributor

I think @alextea mentioned they had user research suggesting that people do indeed use the home breadcrumb on it's own.

@alextea
Copy link
Contributor

alextea commented Jan 25, 2017

@NickColley we've not tested showing pages with just "Home", so not sure about that, but not all users understand that the logo is a link so I think adding this is a step in the right direction.

@bevanloon
Copy link
Contributor

Just to weigh in - I'm currently fixing a bug in whitehall's statistical data set presenter to include parent in the links hash. So I think statistical data sets, at least, will need breadcrumbs anyway.

In general, I'll echo @fofr on the 👍 for simplification, but also raise a question about the user need for a single breadcrumb that only goes home.

@carolinegreen
Copy link

@NickColley In a lot of the user research users would go to click the "Home" breadcrumb link first before anything else, but like Alex said we haven't tested pages with home on it's own.

@tijmenb
Copy link
Contributor Author

tijmenb commented Jan 25, 2017

We've also done a quick research in analytics just now:

If we take https://www.gov.uk/aaib-reports as an example of a page with only a "Home" breadcrumb. It has 7,691 unique pageviews over the last month, of which 160 people clicked "Home". That's quite a lot.

Overall in the last 30 days 741,789 people clicked the "Home" in the breadcrumb, mostly from browse & done pages.

screen shot 2017-01-25 at 16 04 19

@tijmenb tijmenb merged commit 3f2ed53 into master Jan 25, 2017
@tijmenb tijmenb deleted the consistent-breadcrumbs branch January 25, 2017 16:09
tijmenb added a commit that referenced this pull request Jan 25, 2017
#238 introduced
breadcrumbs on all pages. Because HTML publications weren't in the list
of migrated formats in the readme (fixed in
#239) I hadn't
checked that. @fofr helpfully pointed me to that.

Because HTML publications have its publication in the links as
`parent`, the breadcrumb magically shows the parent publication. This
means we can remove the link on the right. Because the breadcrumb takes
care of its own height, we no longer need to include the
responsive-top-margin mixin.
tijmenb added a commit that referenced this pull request Jan 25, 2017
#238 introduced
breadcrumbs on all pages. Because HTML publications weren't in the list
of migrated formats in the readme (fixed in
#239) I hadn't
checked that. @fofr helpfully pointed me to that.

Because HTML publications have its publication in the links as
`parent`, the breadcrumb magically shows the parent publication. This
means we can remove the link on the right. Because the breadcrumb takes
care of its own height, we no longer need to include the
responsive-top-margin mixin.
tijmenb added a commit that referenced this pull request Jan 25, 2017
#238 introduced
breadcrumbs on all pages. Because HTML publications weren't in the list
of migrated formats in the readme (fixed in
#239) I hadn't
checked that. @fofr helpfully pointed me to that.

Because HTML publications have its publication in the links as
`parent`, the breadcrumb magically shows the parent publication. This
means we can remove the link on the right. Because the breadcrumb takes
care of its own height, we no longer need to include the
responsive-top-margin mixin.
@fofr
Copy link
Contributor

fofr commented Mar 7, 2017

We should validate that "Home" takes people to the place they expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants