Merge contacts frontend into government frontend #253
Conversation
NickColley
requested review from
gpeng,
fofr,
boffbowsh,
NickColley and
andrewgarner
|
This didn't previously have the beta banner and I can't easily see a description of why and where it got added. |
|
We removed the beta banner since no product team is iterating contacts at the moment. So it felt like something that should have been removed a long time ago. I'd be happy to put it back if there's a good reason to though. 👍 Edit: Just noticed the screenshots were in the wrong order. :) |
| //= require_tree ./modules | ||
| //= require webchat.js |
There was a problem hiding this comment.
Could we include this only on pages that have webchat? This would other wise be downloaded for every format.
There was a problem hiding this comment.
I'd be 👍 for that, seems like a good thing.
|
Can the commit message for 3cc1e1c be updated with a link to the history of the original webchat feature? |
test/integration/contact_test.rb
Outdated
| end | ||
|
|
||
|
|
||
| test "post are rendered" do |
There was a problem hiding this comment.
"post are rendered" (also, whitespace)
| end | ||
|
|
||
| test 'presents the format' do | ||
| assert_equal schema_item['format'], presented_item.format |
There was a problem hiding this comment.
I think we can remove this test
| end | ||
|
|
||
| test 'phone returns correctly' do | ||
| assert_equal schema_item['details']['phone_numbers'][0]["number"], presented_item.phone[0][:numbers][0][:number] |
There was a problem hiding this comment.
I'd save schema_item['details']['phone_numbers'][0] in a variable
test/integration/contact_test.rb
Outdated
| assert_not_nil html.at_css(".street-address") | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
There's no test that the related links component is rendered with the correct parameters.
|
What's holding this up? It also needs a rebase with master after travel advice was added. |
|
Just me trying to find time to update this PR, I'm close to getting in a few commits that address the rest of your comments. ⏲ |
|
I've updated the PR so that Webchat is only loaded when it's needed. We should test this in production mode that the webchat payload is only loaded when needed etc. |
NickColley
changed the title
Adds bold behaviour
Initial commit, just to make sure the tests pass when ported. The original Webchat work was originally completed by Theodore Vararu, he documented some of this here: https://docs.google.com/document/d/1sXPauPRnMT-kxBBCafDy5T4uVDAoLA1CF0ZEOmtYYuk/edit
as pointed out by @fofr these are not needed
README.md
Outdated
| @@ -17,6 +17,7 @@ Not all formats that this app can handle are rendered by it in production. | |||
| | Case study | [View on GOV.UK](https://www.gov.uk/government/case-studies/2013-elections-in-swaziland) | Migrated | | |||
| | Coming soon | | Rendered by Whitehall | | |||
| | Consultation | [View on GOV.UK](https://www.gov.uk/government/consultations/soft-drinks-industry-levy) | Migrated | | |||
| | contacts | [View on GOV.UK](https://www.gov.uk/government/organisations/hm-revenue-customs/contact/alcohol-duties-national-registration-unit) | Currently rendered by Contacts frontend | | |||
|
For 7f2cf72 can you also revert the changes to application.js: https://github.com/alphagov/government-frontend/pull/253/files#diff-a9c3bd311eab80c9ebe6a69830f9ad02 (Also, there's a typo in commit) |
webchat is a legacy module that is not written in the standard GOV.UK module pattern. This module is going to be looked at being rewritten in firebreak. while just calling it legacy and been done with it is not ideal, we are looking at it in short order. Also add contacts to readme and revert the change to application.js back to just include the modules directory
This is the first part of the template consolidation work. This renders contacts frontend in government frontend.
part of :- https://trello.com/c/0Ree9gt0/140-3-render-contacts-in-government-frontend-l
it handles all the rendering, and Webchat that was handled by contacts frontend. Please note, the webchat was taken in as is, as it is being handled in firebreak
The breadcrumbs are awaiting on work from the finding things team.
the contacts template is using govspeak css and will be having a going over with the content team to make it more consistent. the reason Govspeak was used was to introduce more consistency as opposed to specific styles per template.
you can see changes supplied by wraith here https://template-consolidation-contacts-diff.surge.sh/
this pull is dependent on updating the schemas