Education navigation ab testing #256
Conversation
| @@ -137,15 +137,13 @@ class ContentItemsControllerTest < ActionController::TestCase | |||
|
|
|||
| content_store_has_item(content_item['base_path'], content_item) | |||
|
|
|||
| with_variant EducationNavigation: "A" do | |||
There was a problem hiding this comment.
What's the issue with using with_variant here? Is it something we should change in the A/B gem?
There was a problem hiding this comment.
No, it's just that I incorrectly added the meta tag and response headers before, where they shouldn't be applied if we've not got content tagged to a taxon.
There was a problem hiding this comment.
In that case, you could include the assert_response_not_modified_for_ab_test assertion, which will check that the meta tag and response headers haven't been added.
| get :show, params: { path: path_for(content_item) } | ||
| assert_equal [], @request.variant | ||
| end | ||
| setup_ab_variant('educationnavigation', 'A') |
There was a problem hiding this comment.
This should be EducationNavigation to match the casing elsewhere.
| get :show, params: { path: path_for(content_item) } | ||
| assert_equal [], @request.variant | ||
| end | ||
| setup_ab_variant('educationnavigation', 'B') |
alecgibson
force-pushed
the
education-navigation-ab-testing
branch
from
e9bff05 to
6b6e732
Compare
|
@suzannehamilton the templates are probably worth reviewing in case I missed anything. Sorry the diffing isn't easier. |
| @@ -0,0 +1,3 @@ | |||
| <div class="national-statistics-logo"> | |||
There was a problem hiding this comment.
Why does this logo need a new_navigation file? Is it different in the A and B versions?
There was a problem hiding this comment.
Yes - it was in a one-third-column div
alecgibson
force-pushed
the
education-navigation-ab-testing
branch
from
6b6e732 to
54c9487
Compare
This extends the styling changes made in #237 to also encompass the following content item schemas:
document_collectionpublicationThe changes are to:
metatag to these documents to indicate that they are in an A/B test (when their content is tagged to a taxon)Varyheader on responses from these documentsTrello
https://trello.com/c/jd56fcgd/338-changes-to-education-related-content-pages-as-part-of-the-new-navigation-in-government-frontend-part-2