Remove suggested_ordered_related_items #3005
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the [related links recommender](https://github.com/alphagov/govuk-related-links-recommender) is no longer running, suggested_ordered_related_items will be growing increasingly stale. I'm not sure whether publishing-api is even clever enough to keep suggested_ordered_related_items links somewhat up to date (e.g. if one is withdrawn, unpublished, or if a slug is changed) - it doesn't look like it from [a cursory glance at the code](https://github.com/alphagov/publishing-api/blob/main/lib/expansion_rules.rb). Note that there are around 164,000 published editions with suggested_ordered_related_items and only around 2,500 published editions with ordered_related_items, so this will have the effect of removing the related links sidebar from the majority of pages on GOV.UK (around 161,000 of them).
richardTowers
force-pushed
the
remove-suggested-related-items
branch
from
bf1bd46
to
c38f329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the related links recommender
is no longer running, suggested_ordered_related_items will be growing
increasingly stale.
I'm not sure whether publishing-api is even clever enough to keep
suggested_ordered_related_items links somewhat up to date (e.g. if one
is withdrawn, unpublished, or if a slug is changed) - it doesn't look
like it from a cursory glance at the code.
Note that there are around 164,000 published editions with
suggested_ordered_related_items and only around 2,500 published editions
with ordered_related_items, so this will have the effect of removing the
related links sidebar from the majority of pages on GOV.UK (around
161,000 of them).